Bug 86775

Summary: Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85555    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-05-17 14:19:36 PDT
Currently we take floats but always paint at whole y coordinates. This patch will preserve that behavior with the sub-pixel conversion. Otherwise, some underlines and strike-throughs end up midway between two pixels.
Attachments
Patch (1.67 KB, patch)
2012-05-17 14:26 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-05-17 14:26:35 PDT
Created attachment 142556 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-17 14:28:18 PDT
Comment on attachment 142556 [details] Patch Does Skia floor the X for us? I'm confused?
Levi Weintraub
Comment 3 2012-05-17 18:54:14 PDT
(In reply to comment #2) > (From update of attachment 142556 [details]) > Does Skia floor the X for us? I'm confused? I'm going to add a comment. We always draw these lines horizontally. Sub-pixel x values are normal and acceptable.
Levi Weintraub
Comment 4 2012-05-24 10:23:55 PDT
Forgot to comment... landed in r117528 <http://trac.webkit.org/changeset/117528>
Note You need to log in before you can comment on or make changes to this bug.