Bug 81124

Summary: [EFL] Implement LayoutTestController::setEditingBehavior
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80126    
Bug Blocks: 81130    
Attachments:
Description Flags
Implement setEditingBehavior
gyuyoung.kim: commit-queue-
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-03-14 09:23:28 PDT
Implement LayoutTestController::setEditingBehavior for EFL port so that we can unskip related tests from the skip list.
Attachments
Implement setEditingBehavior (4.13 KB, patch)
2012-03-14 09:41 PDT, Sudarsana Nagineni (babu) 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch (6.43 KB, patch)
2012-03-21 11:56 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (6.47 KB, patch)
2012-03-22 07:47 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-03-14 09:41:46 PDT
Created attachment 131870 [details] Implement setEditingBehavior
Gyuyoung Kim
Comment 2 2012-03-14 17:41:11 PDT
Comment on attachment 131870 [details] Implement setEditingBehavior Attachment 131870 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11953551
Gyuyoung Kim
Comment 3 2012-03-14 19:00:38 PDT
Comment on attachment 131870 [details] Implement setEditingBehavior View in context: https://bugs.webkit.org/attachment.cgi?id=131870&action=review > LayoutTests/platform/efl/Skipped:736 > +# Set unicode backspace value in EFL's createKeyMaap Minor nit : %s/createKeyMaap/createKeyMap/g > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722 > + ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN); EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared.
Sudarsana Nagineni (babu)
Comment 4 2012-03-14 23:07:56 PDT
(In reply to comment #3) Thanks for your review! > > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722 > > + ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN); > > EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared. This is dependent on bug #80126 fix.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-03-21 11:50:56 PDT
*** Bug 80126 has been marked as a duplicate of this bug. ***
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-03-21 11:51:56 PDT
(In reply to comment #5) > *** Bug 80126 has been marked as a duplicate of this bug. *** As discussed in bug 80126, we're not adding anything to ewk_view anymore; instead, we're just adding some API to DumpRenderTreeSupportEfl. As it's all related to setEditingBehavior, it makes more sense to land everything in a single patch.
Sudarsana Nagineni (babu)
Comment 7 2012-03-21 11:56:28 PDT
Created attachment 133087 [details] Patch Merged 80126 fix into this one.
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-03-21 11:58:17 PDT
Comment on attachment 133087 [details] Patch Looks fine, thanks.
Martin Robinson
Comment 9 2012-03-22 07:26:04 PDT
Comment on attachment 133087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133087&action=review > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:428 > + else > + return; Maybe it would be good to put an ASSERT_NOT_REACHED here?
Sudarsana Nagineni (babu)
Comment 10 2012-03-22 07:47:46 PDT
Created attachment 133263 [details] Patch fixed comment #9.
WebKit Review Bot
Comment 11 2012-03-22 08:51:03 PDT
Comment on attachment 133263 [details] Patch Clearing flags on attachment: 133263 Committed r111709: <http://trac.webkit.org/changeset/111709>
WebKit Review Bot
Comment 12 2012-03-22 08:51:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.