Bug 81118

Summary:

[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream

Product:

WebKit

Reporter:

Nima Ghanavatian <nima.ghanavatian>

Component:

WebKit BlackBerry

Assignee:

Nima Ghanavatian <nima.ghanavatian>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

anilsson, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

81108

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Nima Ghanavatian

Reported 2012-03-14 08:56:10 PDT

This is a consolidation of various changes that are in our local dev branch but do not appear in our upstreamed port.

Attachments
Patch (10.43 KB, patch) 2012-03-14 09:01 PDT, Nima Ghanavatian	no flags	Details Formatted Diff Diff
Patch (10.43 KB, patch) 2012-03-14 10:19 PDT, Nima Ghanavatian	no flags	Details Formatted Diff Diff
Patch (10.56 KB, patch) 2012-03-16 12:47 PDT, Nima Ghanavatian	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Nima Ghanavatian

Comment 1 2012-03-14 09:01:09 PDT

Created attachment 131866 [details] Patch

Rob Buis

Comment 2 2012-03-14 09:05:55 PDT

Comment on attachment 131866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131866&action=review Looks good, but see the typo. > Source/WebKit/blackberry/ChangeLog:3 > + [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to ups tream Copy paste error? :)

Nima Ghanavatian

Comment 3 2012-03-14 10:19:57 PDT

Created attachment 131875 [details] Patch

Rob Buis

Comment 4 2012-03-14 10:28:41 PDT

Comment on attachment 131875 [details] Patch Looks good.

Nima Ghanavatian

Comment 5 2012-03-14 19:06:38 PDT

Pulling from commit-queue. Noticed some errors in this commit. Will have to rework it.

Nima Ghanavatian

Comment 6 2012-03-16 12:47:49 PDT

Created attachment 132353 [details] Patch