Bug 40893

Summary: CLEANUP: Take care of the comments in bug 40084
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: FormsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED INVALID    
Severity: Minor CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 40184    
Bug Blocks: 39021    
Attachments:
Description Flags
Patch darin: review+

Dimitri Glazkov (Google)
Reported 2010-06-20 14:10:33 PDT
The comments here need to be addressed: https://bugs.webkit.org/show_bug.cgi?id=40084#c14
Attachments
Patch (5.11 KB, patch)
2010-06-22 09:49 PDT, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-06-22 09:49:39 PDT
Created attachment 59380 [details] Patch
Darin Adler
Comment 2 2010-06-22 11:03:10 PDT
Comment on attachment 59380 [details] Patch > -FormSubmission::FormSubmission(Method method, const KURL& action, const String& target, const String& contentType, PassRefPtr<FormState> state, PassRefPtr<FormData> data, const String& boundary, bool lockHistory, PassRefPtr<Event> event) I suggest just adding the "inline" keyword in front of this constructor definition. Since it's only used in the create function, there's no need to move it to the header. Also, the version in the header uses formatting that is not standard for WebKit, not indenting the member initializer list. r=me
Dimitri Glazkov (Google)
Comment 3 2010-06-22 20:45:33 PDT
Ha! My clean-up patch manages to need its own fixups. Sorry for such a rush job. Will fix and land as you suggested.
Dimitri Glazkov (Google)
Comment 4 2010-06-23 16:32:44 PDT
Folded into bug 41110.
Note You need to log in before you can comment on or make changes to this bug.