Bug 39056

Summary: fast/forms/implicit-submission.html is flakey
Product: WebKit Reporter: Takeshi Yoshino <tyoshino>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, mathias, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 9756    
Bug Blocks: 39021    
Attachments:
Description Flags
Proposed patch - revision 0
none
Patch
none
Make it work without DRT. none

Takeshi Yoshino
Reported 2010-05-13 05:07:21 PDT
I'd like to update test_expectations.txt for fast/forms/implicit-submission.html on Chromium http://code.google.com/p/chromium/issues/detail?id=43890
Attachments
Proposed patch - revision 0 (1.15 KB, patch)
2010-05-13 05:09 PDT, Takeshi Yoshino 		no flags
DetailsFormatted DiffDiff
Patch (4.88 KB, patch)
2012-04-06 16:13 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Make it work without DRT. (4.95 KB, patch)
2012-04-06 16:16 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Takeshi Yoshino
Comment 1 2010-05-13 05:09:20 PDT
Created attachment 55963 [details] Proposed patch - revision 0
Shinichiro Hamaji
Comment 2 2010-05-13 05:10:48 PDT
Comment on attachment 55963 [details] Proposed patch - revision 0 Rubber stamping
Takeshi Yoshino
Comment 3 2010-05-13 05:20:27 PDT
Thank you for quick work.
WebKit Commit Bot
Comment 4 2010-05-15 17:02:05 PDT
Comment on attachment 55963 [details] Proposed patch - revision 0 Rejecting patch 55963 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1 Last 500 characters of output: eded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: platform/chromium/test_expectations.txt |=================================================================== |--- platform/chromium/test_expectations.txt (revision 59170) |+++ platform/chromium/test_expectations.txt (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://webkit-commit-queue.appspot.com/results/2293130
Adam Barth
Comment 5 2010-05-15 17:46:44 PDT
Looks like this was landed already. Note: the patch was incorrectly based in LayoutTests instead of the root. Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.
Dimitri Glazkov (Google)
Comment 6 2010-05-15 19:57:53 PDT
:( I didn't expect this test to be flakey. I wrote it, btw. Hijacking this bug to fix.
Takeshi Yoshino
Comment 7 2010-05-16 23:36:09 PDT
(In reply to comment #5) > Looks like this was landed already. > Note: the patch was incorrectly based in LayoutTests instead of the root. Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based. Sorry for that. I'll do so from the next time. Thank you.
Eric Seidel (no email)
Comment 8 2010-05-17 00:48:50 PDT
Comment on attachment 55963 [details] Proposed patch - revision 0 Obsoleting patch since it was landed.
Dimitri Glazkov (Google)
Comment 9 2012-04-06 16:13:13 PDT
Created attachment 136087 [details] Patch
Dimitri Glazkov (Google)
Comment 10 2012-04-06 16:16:42 PDT
Created attachment 136091 [details] Make it work without DRT.
Hajime Morrita
Comment 11 2012-04-10 18:12:39 PDT
Comment on attachment 136091 [details] Make it work without DRT. View in context: https://bugs.webkit.org/attachment.cgi?id=136091&action=review > LayoutTests/fast/forms/implicit-submission.html:134 > + arena.appendChild(a); You are using global-variable-by-id!
WebKit Review Bot
Comment 12 2012-04-10 19:07:49 PDT
Comment on attachment 136091 [details] Make it work without DRT. Clearing flags on attachment: 136091 Committed r113808: <http://trac.webkit.org/changeset/113808>
WebKit Review Bot
Comment 13 2012-04-10 19:07:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.