Bug 264747
| Summary: | [web-animations] `KeyframeValue` and `AcceleratedEffectKeyframe` should derive from a shared base class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 250970, 264756, 264796 | ||
Antoine Quint
As part of the work on threaded animation resolution (see bug 250970), we will need to have the keyframe interpolation logic currently contained in `KeyframeEffect` also apply to `AcceleratedEffect`. This will require a fair amount of refactoring to move all the relevant code in a shared base class for both `KeyframeEffect` and `AcceleratedEffect`.
The first step towards this goal is to have the keyframe class backing those animation effect classes, `KeyframeValue` and `AcceleratedEffectKeyframe`, use a shared base class.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/20420
EWS
Committed 270648@main (893f4b23e527): <https://commits.webkit.org/270648@main>
Reviewed commits have been landed. Closing PR #20420 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/118344599>