Bug 227925

Summary: [iOS & Mac Big Sur Release] Two SOAuthorizationSubFrame API tests are failing
Product: WebKit Reporter: ayumi_kojima
Component: New BugsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, jiewen_tan, katherine_cheney, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227729
Bug Depends on: 227729    
Bug Blocks: 227974    
Attachments:
Description Flags
Patch none

ayumi_kojima
Reported 2021-07-13 15:47:57 PDT
TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync Are failing on iOS 14 E Simulator Release on iPhone 8 and iPad Pro. There seems to be a flaky crash on Big Sur Release on iMac and iOS 14 E Simulator Debug on iPhone 8 as well. History: https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore&test=TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync ===================================== TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2586 Value of: policyForAppSSOPerformed Actual: true Expected: false TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2643 Value of: policyForAppSSOPerformed Actual: true Expected: false ===================================== https://build.webkit.org/#/builders/28/builds/2401/steps/12/logs/stdio
Attachments
Patch (2.45 KB, patch)
2021-07-14 16:43 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-13 16:10:59 PDT
<rdar://problem/80543830>
ayumi_kojima
Comment 2 2021-07-13 16:12:05 PDT
I was not able to reproduce the failure on my local machine using run-api-tests TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore --ios-simulator
Ryan Haddad
Comment 3 2021-07-13 16:12:22 PDT
Probably related to https://trac.webkit.org/changeset/279755/webkit
Brent Fulgham
Comment 4 2021-07-13 16:24:47 PDT
Both of these test cases load apple.com in an iframe. They have a hard-coded 0.5s timeout, which might be insufficient to consistently get the assertion right.
Brent Fulgham
Comment 5 2021-07-14 16:43:03 PDT
Created attachment 433543 [details] Patch
Kate Cheney
Comment 6 2021-07-14 16:46:32 PDT
Comment on attachment 433543 [details] Patch r=me Should we file a bug to track adding them back?
Brent Fulgham
Comment 7 2021-07-14 16:57:00 PDT
(In reply to Kate Cheney from comment #6) > Comment on attachment 433543 [details] > Patch > > r=me > > Should we file a bug to track adding them back? I filed Bug 227974 to do so.
EWS
Comment 8 2021-07-14 17:53:54 PDT
Committed r279935 (239679@main): <https://commits.webkit.org/239679@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433543 [details].
Note You need to log in before you can comment on or make changes to this bug.