Bug 222795

Summary: [LibWebRTC][WPE][GTK] Enable vp9 and NO_MAIN_THREAD_WRAPPING
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, ryuan.choi, sergio, tommyw, tsaunier, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213780, 218221    
Attachments:
Description Flags
[fast-cq] Patch none

Philippe Normand
Reported 2021-03-05 03:50:27 PST
NO_MAIN_THREAD_WRAPPING prevents creating socket server in Web Process. Also I see no reason preventing us to enable H.265 and VP9, unless I missed something?
Attachments
[fast-cq] Patch (35.42 KB, patch)
2021-04-21 07:46 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-03-05 04:33:23 PST
Actually I'm not sure H.265 makes much sense for us, VP9 should cover most cases nowadays.
Philippe Normand
Comment 2 2021-04-21 07:46:36 PDT
Created attachment 426682 [details] [fast-cq] Patch
Xabier Rodríguez Calvar
Comment 3 2021-04-22 01:37:54 PDT
Comment on attachment 426682 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426682&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:159 > + gst_bin_add_many(GST_BIN_CAST(m_pipeline.get()), m_src.get(), videoconvert, videoscale, m_capsFilter.get(), m_encoder.get(), m_sink.get(), nullptr); > + if (!gst_element_link_many(m_src.get(), videoconvert, videoscale, m_capsFilter.get(), m_encoder.get(), m_sink.get(), nullptr)) { > + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN_CAST(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error"); I think we should at least warn here as well.
Philippe Normand
Comment 4 2021-04-22 06:42:25 PDT
A glib warning is already raised when linking fails. In fact this is the only place where we check a _link_many return value. I wonder if it makes much sense anyway. :)
EWS
Comment 5 2021-04-23 02:23:14 PDT
Committed r276491 (236950@main): <https://commits.webkit.org/236950@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426682 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-23 13:11:56 PDT
<rdar://problem/77083214>
Note You need to log in before you can comment on or make changes to this bug.