Bug 183941

Summary:

WebProcessPool should not ask to register all clients for each service worker process creation

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, commit-queue, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

183873

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Fixing bad session ID	none
Fixing bad session ID	none

youenn fablet

Reported 2018-03-23 10:16:06 PDT

Now that we can have more than one, this triggers useless IPC.

Attachments
Patch (9.81 KB, patch) 2018-03-23 11:28 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (9.69 KB, patch) 2018-03-23 11:49 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.58 MB, application/zip) 2018-03-23 12:54 PDT, EWS Watchlist	no flags	Details
Fixing bad session ID (9.91 KB, patch) 2018-03-23 12:59 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing bad session ID (9.90 KB, patch) 2018-03-23 13:01 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-03-23 11:28:15 PDT

Created attachment 336395 [details] Patch

youenn fablet

Comment 2 2018-03-23 11:49:19 PDT

Created attachment 336397 [details] Patch

Chris Dumez

Comment 3 2018-03-23 12:47:10 PDT

Comment on attachment 336397 [details] Patch EWS may be unhappy.

EWS Watchlist

Comment 4 2018-03-23 12:54:41 PDT

Comment on attachment 336397 [details] Patch Attachment 336397 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7077480 New failing tests: http/tests/inspector/network/resource-response-service-worker.html imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/default-reader.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/cancel.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-byte-streams/general.serviceworker.https.html http/tests/workers/service/postmessage-after-sw-process-crash.https.html imported/w3c/web-platform-tests/FileAPI/historical.https.html imported/w3c/web-platform-tests/streams/readable-byte-streams/properties.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https.html imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html http/tests/workers/service/Client-properties-auxiliary.html imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https.html http/tests/appcache/main-resource-redirect-with-sw.html http/wpt/service-workers/check-service-worker-header.https.html imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/close.https.html imported/w3c/web-platform-tests/streams/readable-byte-streams/brand-checks.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/general.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https.html imported/w3c/web-platform-tests/streams/readable-streams/templated.serviceworker.https.html imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html

EWS Watchlist

Comment 5 2018-03-23 12:54:42 PDT

Created attachment 336411 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 6 2018-03-23 12:59:54 PDT

Created attachment 336412 [details] Fixing bad session ID

youenn fablet

Comment 7 2018-03-23 13:01:59 PDT

Created attachment 336413 [details] Fixing bad session ID

WebKit Commit Bot

Comment 8 2018-03-23 13:52:31 PDT

The commit-queue encountered the following flaky tests while processing attachment 336413 [details]: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html bug 183949 (author: graouts@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 9 2018-03-23 13:53:06 PDT

Comment on attachment 336413 [details] Fixing bad session ID Clearing flags on attachment: 336413 Committed r229917: <https://trac.webkit.org/changeset/229917>

WebKit Commit Bot

Comment 10 2018-03-23 13:53:07 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2018-03-23 13:54:25 PDT

<rdar://problem/38806075>

youenn fablet

Comment 12 2018-03-23 17:12:53 PDT

*** Bug 182443 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.