Bug 104650

Summary: INPUT_MULTIPLE_FIELDS_UI: Support focus navigation by left/right keys in RTL locales
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED LATER    
Severity: Normal CC: dglazkov, forms-bugs, hayato, morrita, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61412    
Attachments:
Description Flags
WIP
none
Patch
none
Patch 2
none
Patch 3 none

Kent Tamura
Reported 2012-12-11 01:27:31 PST
We disables it in Bug 104644. We need to make FocusController::advanceFocus(FocusDirectionLeft/Right,...) workable for shadow nodes.
Attachments
WIP (10.42 KB, patch)
2012-12-13 00:19 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (15.11 KB, patch)
2012-12-13 20:08 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (15.32 KB, patch)
2012-12-16 20:12 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (14.22 KB, patch)
2013-01-18 00:45 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-12-13 00:19:38 PST
Created attachment 179218 [details] WIP
WebKit Review Bot
Comment 2 2012-12-13 01:57:52 PST
Comment on attachment 179218 [details] WIP Attachment 179218 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15312195 New failing tests: fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html
Kent Tamura
Comment 3 2012-12-13 20:08:34 PST
Created attachment 179405 [details] Patch
Build Bot
Comment 4 2012-12-14 03:34:04 PST
Comment on attachment 179405 [details] Patch Attachment 179405 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15309647 New failing tests: fast/spatial-navigation/snav-media-elements.html
Kent Tamura
Comment 5 2012-12-16 20:12:12 PST
Created attachment 179684 [details] Patch 2 Fix media elements failure
Hayato Ito
Comment 6 2012-12-16 21:54:48 PST
Comment on attachment 179684 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=179684&action=review > Source/WebCore/dom/NodeTraversal.cpp:132 > +namespace ElementTraversalWithShadow { Can we use ComposedShadowTreeWalker to traverse nodes in shadow trees? It seems a kind of duplications for me.
Kent Tamura
Comment 7 2012-12-16 22:38:10 PST
Comment on attachment 179684 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=179684&action=review >> Source/WebCore/dom/NodeTraversal.cpp:132 >> +namespace ElementTraversalWithShadow { > > Can we use ComposedShadowTreeWalker to traverse nodes in shadow trees? > It seems a kind of duplications for me. I don't know because I don't understand ComposedShadowTreeWalker well. - What is "composed" shadow tree? - Will it be wrapped with ENABLE_SHADOW_DOM? - Does it work for non-shadow nodes? - Is the traversal order same as NodeTraversal/ElementTraversal? - Does it have a function like NodeTraversal::nextSkippingChildren? - What is UpperBoundary?
Hajime Morrita
Comment 8 2013-01-06 17:19:14 PST
Comment on attachment 179684 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=179684&action=review >>> Source/WebCore/dom/NodeTraversal.cpp:132 >>> +namespace ElementTraversalWithShadow { >> >> Can we use ComposedShadowTreeWalker to traverse nodes in shadow trees? >> It seems a kind of duplications for me. > > I don't know because I don't understand ComposedShadowTreeWalker well. > > - What is "composed" shadow tree? > - Will it be wrapped with ENABLE_SHADOW_DOM? > - Does it work for non-shadow nodes? > - Is the traversal order same as NodeTraversal/ElementTraversal? > - Does it have a function like NodeTraversal::nextSkippingChildren? > - What is UpperBoundary? I added NodeRenderingTraversal.h (http://trac.webkit.org/browser/trunk/Source/WebCore/dom/NodeRenderingTraversal.h) That is basically SHADOW_DOM flag agnostic version of shadow tree traversal routines. It would be great if we can make these to fit there. I'm thinking about hiding ComposedShadowTreeWalker behind the flag. But it's long way to go.
Kent Tamura
Comment 9 2013-01-18 00:07:40 PST
(In reply to comment #7) > - Does it have a function like NodeTraversal::nextSkippingChildren? I found CSTW didn't have this feature. Also, CSTW doesn't have the stayWithin feature.
Kent Tamura
Comment 10 2013-01-18 00:45:40 PST
Created attachment 183397 [details] Patch 3 Use CSTW
Kent Tamura
Comment 11 2013-03-21 20:35:46 PDT
We already shipped this behavior for LTR locales a few months ago, and we haven't seen any requests to support RTL locales. IMO we don't need to do this change yet.
Note You need to log in before you can comment on or make changes to this bug.